Open
Conversation
devanshu-puri
force-pushed
the
improve-run-command
branch
from
e8a3b6e to
01af1cc
Compare
Collaborator
|
Hey @devanshu-puri, great work, but the preset is currently loading only for the ADSR envelope, can you please modify your code to include waveform, octave and equalizer too. I see that you have tried to add EQ preset, but it isn't implemented properly. Also prefer to use camel case wherever applicable. |
Author
|
have fixed all issue and all requirement are satisfied now. :) |
baync180705
requested changes
Oct 23, 2025
Collaborator
baync180705
left a comment
baync180705
left a comment
There was a problem hiding this comment.
Hey @devanshu-puri, the same bug still persists. Only the ADSR values are getting loaded. The waveform, octave, EQ etc retain their default value instead of what should have been as per the previous preset saved.
Kindly look into it once test it locally once. If you need any help in troubleshooting, do let us know.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @baync180705 @mohitvermax ,
I’ve implemented the preset save & load functionality as discussed:
initail presets
SAVING PRESET GIVE A DOWNLOADABLE JSON FILE
LOADING IT WITH THE LOADED PRESET
Centralized all synthesizer parameters (ADSR, EQ, waveform, octave, rawWave) into a single synthState object.
Added Save Preset feature to export current settings as a JSON file with a timestamp.
Added Load Preset feature to import JSON presets and restore all synth settings.
Wrapped file parsing in try…catch and added basic validation for safety.
Added simple alert feedback for successful save/load or errors.
The core functionality is complete and should meet the original requirements. Optional enhancements like toast notifications, localStorage, and a “Reset to Default” button can be added in the next iteration.
Looking forward to your review!